Check for nullptr when getting appdata_path #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, there is no check to ensure
std::getenvhas returned a non-null value in detail::getenvcompute/include/boost/compute/detail/getenv.hpp
Line 26 in 36350b7
If it is unable to find the APPDATA or HOME env var, it returns a nullptr.
appdata_paththen tries to use this nullptr to build a string. Updated appdata_path to log an error if a nullptr is returned.(Context: ran into an issue with this while using LightGBM where the program was unexpectedly crashing without any error due to $HOME not being set.)